Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Update devupdate with FA6 info #1085

Merged
merged 1 commit into from
Aug 16, 2024
Merged

[docs] Update devupdate with FA6 info #1085

merged 1 commit into from
Aug 16, 2024

Conversation

sarjona
Copy link
Member

@sarjona sarjona commented Jul 19, 2024

This issue is to document changes done in MDL-82497, MDL-82211 and MDL-82210.

@netlify Netlify
Copy link

netlify bot commented Jul 19, 2024 •
edited
Loading

✅ Deploy Preview for moodledevdocs ready!

Name Link
🔨 Latest commit 64625a4
🔍 Latest deploy log https://app.netlify.com/sites/moodledevdocs/deploys/66b5b1ba2b5a9500083f0e57
😎 Deploy Preview https://deploy-preview-1085--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 19, 2024 •
edited
Loading

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🔴 39 🟢 95 🟢 100 🟢 90 🟢 100 Report
/docs/4.4/apis/commonfiles 🟠 66 🟢 93 🟢 100 🟢 100 🟢 100 Report
/general/development/gettingstarted 🟠 75 🟢 95 🟢 100 🟢 90 🟢 100 Report
/general/releases 🟠 78 🟢 95 🟢 100 🟢 100 🟢 100 Report

kabalin
kabalin reviewed Aug 8, 2024
View reviewed changes
docs/devupdate.md Outdated Show resolved Hide resolved
kabalin
kabalin reviewed Aug 8, 2024
View reviewed changes
docs/devupdate.md Outdated Show resolved Hide resolved
kabalin
kabalin reviewed Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@kabalin kabalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of formatting suggestions.

@sarjona
Copy link
Member Author

sarjona commented Aug 9, 2024

Hi @kabalin!
Thanks a lot for reviewing this. I updated the patch with the changes (well spotted!) and I rebased it too :-)

aanabit
aanabit approved these changes Aug 9, 2024
View reviewed changes
Copy link
Collaborator

@aanabit aanabit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes seems OK to me

@sarjona sarjona added this pull request to the merge queue Aug 16, 2024
Merged via the queue into moodle:main with commit 22484e7 Aug 16, 2024
7 checks passed
@sarjona sarjona deleted the fa6icons branch August 16, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kabalin kabalin kabalin left review comments

@aanabit aanabit aanabit approved these changes

Assignees

@sarjona sarjona

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sarjona @kabalin @aanabit